Review Request 123465: Add support for SSH VPN plugin

[Jan Grulich]

> On Dub. 22, 2015, 2:09 odp., Lamarque Souza wrote:
> > vpn/ssh/sshwidget.cpp, line 349
> > <https://git.reviewboard.kde.org/r/123465/diff/1/?file=362373#file362373line349>
> >
> >     You should use SettingWidget::EnumPasswordStorageType::{Store,AlwaysAsk,NotRequired} as index for all secret flags comboboxes throughout Plasma NM. Here you sorted them as AgentOwned, NotRequired, AlwaysAsk, but in other comboboxes in Plasma NM the order is AgentOwned, AlwaysAsk, NotRequired. If you use SettingWidget::EnumPasswordStorageType::{Store,AlwaysAsk,NotRequired} the order will be same for all comboboxes and there are a lot of them in Plasma NM.

My order is correct, all VPN plugins use AgentOwned (stored), AlwaysAsk, NotRequired, but you are right I should have used SettingWidget::EnumPasswordStorageType enum. It's a code copied from another VPN plugin and it sets correct values, but in a wrong order. I'll fix this also in the second VPN plugin I used as inspiration.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123465/#review79341
-----------------------------------------------------------


On Dub. 22, 2015, 2:41 odp., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123465/
> -----------------------------------------------------------
> 
> (Updated Dub. 22, 2015, 2:41 odp.)
> 
> 
> Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
> 
> 
> Bugs: 341070
>     http://bugs.kde.org/show_bug.cgi?id=341070
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> This patch adds support for SSH VPN plugin (according to nm-connection-editor).
> 
> 
> Diffs
> -----
> 
>   libs/editor/simpleipv4addressvalidator.h 9a4e270 
>   libs/editor/simpleipv6addressvalidator.h 934dc99 
>   vpn/CMakeLists.txt 714fff0 
>   vpn/ssh/CMakeLists.txt PRE-CREATION 
>   vpn/ssh/Messages.sh PRE-CREATION 
>   vpn/ssh/nm-ssh-service.h PRE-CREATION 
>   vpn/ssh/plasmanetworkmanagement_sshui.desktop PRE-CREATION 
>   vpn/ssh/ssh.h PRE-CREATION 
>   vpn/ssh/ssh.cpp PRE-CREATION 
>   vpn/ssh/sshadvanced.ui PRE-CREATION 
>   vpn/ssh/sshauth.h PRE-CREATION 
>   vpn/ssh/sshauth.cpp PRE-CREATION 
>   vpn/ssh/sshauth.ui PRE-CREATION 
>   vpn/ssh/sshwidget.h PRE-CREATION 
>   vpn/ssh/sshwidget.cpp PRE-CREATION 
>   vpn/ssh/sshwidget.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123465/diff/
> 
> 
> Testing
> -------
> 
> I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150422/27c2824c/attachment.html>