<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123465/">https://git.reviewboard.kde.org/r/123465/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On duben 22nd, 2015, 2:09 odp. UTC, <b>Lamarque Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123465/diff/1/?file=362373#file362373line349" style="color: black; font-weight: bold; text-decoration: underline;">vpn/ssh/sshwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">349</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">combo</span><span class="o">-></span><span class="n">setCurrentIndex</span><span class="p">(</span><span class="mi">0</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You should use SettingWidget::EnumPasswordStorageType::{Store,AlwaysAsk,NotRequired} as index for all secret flags comboboxes throughout Plasma NM. Here you sorted them as AgentOwned, NotRequired, AlwaysAsk, but in other comboboxes in Plasma NM the order is AgentOwned, AlwaysAsk, NotRequired. If you use SettingWidget::EnumPasswordStorageType::{Store,AlwaysAsk,NotRequired} the order will be same for all comboboxes and there are a lot of them in Plasma NM.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My order is correct, all VPN plugins use AgentOwned (stored), AlwaysAsk, NotRequired, but you are right I should have used SettingWidget::EnumPasswordStorageType enum. It's a code copied from another VPN plugin and it sets correct values, but in a wrong order. I'll fix this also in the second VPN plugin I used as inspiration.</p></pre>
<br />
<p>- Jan</p>
<br />
<p>On duben 22nd, 2015, 2:41 odp. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management, Lukáš Tinkl and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Dub. 22, 2015, 2:41 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=341070">341070</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds support for SSH VPN plugin (according to nm-connection-editor).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/editor/simpleipv4addressvalidator.h <span style="color: grey">(9a4e270)</span></li>
<li>libs/editor/simpleipv6addressvalidator.h <span style="color: grey">(934dc99)</span></li>
<li>vpn/CMakeLists.txt <span style="color: grey">(714fff0)</span></li>
<li>vpn/ssh/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/ssh/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/ssh/nm-ssh-service.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/ssh/plasmanetworkmanagement_sshui.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/ssh/ssh.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/ssh/ssh.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/ssh/sshadvanced.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/ssh/sshauth.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/ssh/sshauth.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/ssh/sshauth.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/ssh/sshwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/ssh/sshwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/ssh/sshwidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123465/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>