Review Request 121467: Added support for SSTP VPN in plasma-nm (GCI task)

[Jan Grulich]

> On Pro. 12, 2014, 5:01 odp., Jan Grulich wrote:
> > Do not use classes like KComboBox, KLineEdit or KDialog, those are removed in KDE Frameworks 5. I also don't think you managed to compile this. You need to compile master branch of libnm-qt first (you can see how to compile it in README). Also your plugin is in plasma-2/vpn subdirectory, it should be directly in vpn directory. Before you submit a new version of your patch try to format it according to https://techbase.kde.org/Policies/Kdelibs_Coding_Style.

One more thing, I just compiled SSTP plugin to NetworkManager to compare your UI and you are missing field for certificate, which is quite important and also advanced configuration tab is missing tab for proxy configuration.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121467/#review71885
-----------------------------------------------------------


On Pro. 12, 2014, 4:23 odp., William Boren wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121467/
> -----------------------------------------------------------
> 
> (Updated Pro. 12, 2014, 4:23 odp.)
> 
> 
> Review request for Network Management and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Added support for SSTP VPN in plasma-nm (GCI task)
> 
> 
> Diffs
> -----
> 
>   plasma-nm-2/vpn/sstp/CMakeLists.txt PRE-CREATION 
>   plasma-nm-2/vpn/sstp/Messages.sh PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstp.h PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstp.cpp PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstpadvanced.ui PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstpauth.h PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstpauth.cpp PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstpauth.ui PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstpprop.ui PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstpwidget.h PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstpwidget.cpp PRE-CREATION 
>   plasma-nm-2/vpn/sstp/nm-sstp-service.h PRE-CREATION 
>   plasma-nm-2/vpn/sstp/plasmanetworkmanagement_sstpui.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121467/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> William Boren
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20141212/7333fd34/attachment.html>