<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121467/">https://git.reviewboard.kde.org/r/121467/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On prosinec 12th, 2014, 5:01 odp. UTC, <b>Jan Grulich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do not use classes like KComboBox, KLineEdit or KDialog, those are removed in KDE Frameworks 5. I also don't think you managed to compile this. You need to compile master branch of libnm-qt first (you can see how to compile it in README). Also your plugin is in plasma-2/vpn subdirectory, it should be directly in vpn directory. Before you submit a new version of your patch try to format it according to https://techbase.kde.org/Policies/Kdelibs_Coding_Style.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One more thing, I just compiled SSTP plugin to NetworkManager to compare your UI and you are missing field for certificate, which is quite important and also advanced configuration tab is missing tab for proxy configuration.</p></pre>
<br />
<p>- Jan</p>
<br />
<p>On prosinec 12th, 2014, 4:23 odp. UTC, William Boren wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management and Jan Grulich.</div>
<div>By William Boren.</div>
<p style="color: grey;"><i>Updated Pro. 12, 2014, 4:23 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added support for SSTP VPN in plasma-nm (GCI task)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma-nm-2/vpn/sstp/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-nm-2/vpn/sstp/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-nm-2/vpn/sstp/sstp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-nm-2/vpn/sstp/sstp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-nm-2/vpn/sstp/sstpadvanced.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-nm-2/vpn/sstp/sstpauth.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-nm-2/vpn/sstp/sstpauth.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-nm-2/vpn/sstp/sstpauth.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-nm-2/vpn/sstp/sstpprop.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-nm-2/vpn/sstp/sstpwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-nm-2/vpn/sstp/sstpwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-nm-2/vpn/sstp/nm-sstp-service.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-nm-2/vpn/sstp/plasmanetworkmanagement_sstpui.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121467/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>