Review Request: Fix some UI bugs with high resolution screens

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106961/#review20609
-----------------------------------------------------------



applet/activatableitem.cpp
<http://git.reviewboard.kde.org/r/106961/#comment16245>

    Why did you change this? A 2 pixels icon is too small to be usefull.



applet/activatableitem.cpp
<http://git.reviewboard.kde.org/r/106961/#comment16246>

    Is there any need to change this? 4 is the default spacing in Q*Layout classes.



applet/activatableitem.cpp
<http://git.reviewboard.kde.org/r/106961/#comment16249>

    You are problaby making this icon even smaller than what it is already is.



applet/interfacedetailswidget.cpp
<http://git.reviewboard.kde.org/r/106961/#comment16250>

    Why are you using m_disconnectButton->font() here if it does not have anything to do with m_backButton? Why not use KGlobalSettings::generalFont() intead?



applet/nmpopup.cpp
<http://git.reviewboard.kde.org/r/106961/#comment16251>

    You could make all those QFontMetrics(...).height() calls run just once and use just the result, like I did for rowHeight.



applet/wirelessnetworkitem.cpp
<http://git.reviewboard.kde.org/r/106961/#comment16252>

    this is a spacer, which means it is invisible. There is no need for this change. The height can be any number that does not increase the layout's current height.



applet/wirelessnetworkitem.cpp
<http://git.reviewboard.kde.org/r/106961/#comment16253>

    If the result is the same I rather prefer not to use float point operations  here and the lines below.


- Lamarque Vieira Souza


On Oct. 19, 2012, 10:45 p.m., Michael Zanetti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106961/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2012, 10:45 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Description
> -------
> 
> Some more fixes for Retina screen. Because the font scales with the DPI it doesn't fit any more on the hardcoded button sizes. Here are example screenshots:
> 
> http://notyetthere.org/data/kde/nm-fixed-sizes.png
> http://notyetthere.org/data/kde/nm-dynamic-sizes.png
> 
> 
> Diffs
> -----
> 
>   applet/activatableitem.cpp 1198fd2 
>   applet/interfacedetailswidget.cpp 9635559 
>   applet/interfaceitem.cpp 356c285 
>   applet/nmpopup.cpp a8dfd54 
>   applet/wirelessinterfaceitem.cpp 8f71b20 
>   applet/wirelessnetworkitem.cpp 6489f5d 
> 
> Diff: http://git.reviewboard.kde.org/r/106961/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Zanetti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20121021/d83663df/attachment.html>