<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106961/">http://git.reviewboard.kde.org/r/106961/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106961/diff/1/?file=91205#file91205line43" style="color: black; font-weight: bold; text-decoration: underline;">applet/activatableitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">along with this program. If not, see <http://www.gnu.org/licenses/>.</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">static</span> <span class="k">const</span> <span class="kt">int</span> <span class="n">m_iconSize</span> <span class="o">=</span> <span class="mi">48</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">static</span> <span class="k">const</span> <span class="kt">int</span> <span class="n">m_iconSize</span> <span class="o">=</span> <span class="mi"><span class="hl">2</span></span><span class="p"><span class="hl">;</span></span><span class="c1"><span class="hl">//</span>48;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why did you change this? A 2 pixels icon is too small to be usefull.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106961/diff/1/?file=91205#file91205line51" style="color: black; font-weight: bold; text-decoration: underline;">applet/activatableitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">along with this program. If not, see <http://www.gnu.org/licenses/>.</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">51</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">spacing</span><span class="p">(</span><span class="mi"><span class="hl">4</span></span><span class="p">),</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">51</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">spacing</span><span class="p">(</span><span class="n"><span class="hl">rowHeight</span></span><span class="hl"> </span><span class="o"><span class="hl">/</span></span><span class="hl"> </span><span class="mi"><span class="hl">10</span></span><span class="p">),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there any need to change this? 4 is the default spacing in Q*Layout classes.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106961/diff/1/?file=91205#file91205line78" style="color: black; font-weight: bold; text-decoration: underline;">applet/activatableitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">ActivatableItem::ActivatableItem(RemoteActivatable *remote, QGraphicsItem * parent) : Plasma::IconWidget(parent),</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">78</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_disconnectButton</span><span class="o">-></span><span class="n">setMaximumHeight</span><span class="p">(</span><span class="mi"><span class="hl">16</span></span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">78</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_disconnectButton</span><span class="o">-></span><span class="n">setMaximumHeight</span><span class="p">(</span><span class="n"><span class="hl">QFontMetrics</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">KGlobalSettings</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">generalFont</span></span><span class="p"><span class="hl">()).</span></span><span class="n"><span class="hl">height</span></span><span class="p"><span class="hl">()</span>);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You are problaby making this icon even smaller than what it is already is.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106961/diff/1/?file=91206#file91206line176" style="color: black; font-weight: bold; text-decoration: underline;">applet/interfacedetailswidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">InterfaceDetailsWidget::InterfaceDetailsWidget(QGraphicsItem * parent) : QGraphicsWidget(parent, 0),</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">176</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_backButton</span><span class="o">-></span><span class="n">setMaximumHeight</span><span class="p">(</span><span class="mi">22</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">176</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_backButton</span><span class="o">-></span><span class="n">setMaximumHeight</span><span class="p">(</span><span class="n">QFontMetrics</span><span class="p">(</span><span class="n">m_disconnectButton</span><span class="o">-></span><span class="n">font</span><span class="p">()).</span><span class="n">height</span><span class="p">()</span> <span class="o">+</span> <span class="n">QFontMetrics</span><span class="p">(</span><span class="n">m_disconnectButton</span><span class="o">-></span><span class="n">font</span><span class="p">()).</span><span class="n">xHeight</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why are you using m_disconnectButton->font() here if it does not have anything to do with m_backButton? Why not use KGlobalSettings::generalFont() intead?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106961/diff/1/?file=91208#file91208line105" style="color: black; font-weight: bold; text-decoration: underline;">applet/nmpopup.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void NMPopup::init()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">105</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_leftLabel</span><span class="o">-></span><span class="n">setMaximumHeight</span><span class="p">(</span><span class="mi">24</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">105</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_leftLabel</span><span class="o">-></span><span class="n">setMaximumHeight</span><span class="p">(</span><span class="n">QFontMetrics</span><span class="p">(</span><span class="n">m_leftLabel</span><span class="o">-></span><span class="n">font</span><span class="p">()).</span><span class="n">height</span><span class="p">()</span> <span class="o">+</span> <span class="n">QFontMetrics</span><span class="p">(</span><span class="n">m_leftLabel</span><span class="o">-></span><span class="n">font</span><span class="p">()).</span><span class="n">xHeight</span><span class="p">()</span> <span class="o">*</span> <span class="mi">2</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You could make all those QFontMetrics(...).height() calls run just once and use just the result, like I did for rowHeight.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106961/diff/1/?file=91210#file91210line114" style="color: black; font-weight: bold; text-decoration: underline;">applet/wirelessnetworkitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void WirelessNetworkItem::setupItem()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">114</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">widget</span><span class="o">-></span><span class="n">setMaximumHeight</span><span class="p">(</span><span class="mi"><span class="hl">12</span></span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">114</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">widget</span><span class="o">-></span><span class="n">setMaximumHeight</span><span class="p">(</span><span class="n"><span class="hl">IconSize</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">KIconLoader</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">Small</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="mf"><span class="hl">.75</span></span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is a spacer, which means it is invisible. There is no need for this change. The height can be any number that does not increase the layout's current height.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106961/diff/1/?file=91210#file91210line125" style="color: black; font-weight: bold; text-decoration: underline;">applet/wirelessnetworkitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void WirelessNetworkItem::setupItem()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">125</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_strengthMeter</span><span class="o">-></span><span class="n">setPreferredSize</span><span class="p">(</span><span class="n">QSizeF</span><span class="p">(</span><span class="mi"><span class="hl">60</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="mi"><span class="hl">12</span></span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">125</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_strengthMeter</span><span class="o">-></span><span class="n">setPreferredSize</span><span class="p">(</span><span class="n">QSizeF</span><span class="p">(</span><span class="n"><span class="hl">IconSize</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">KIconLoader</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">Small</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="mi"><span class="hl">4</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">IconSize</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">KIconLoader</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">Small</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="mf"><span class="hl">.75</span></span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If the result is the same I rather prefer not to use float point operations here and the lines below.</pre>
</div>
<br />
<p>- Lamarque Vieira</p>
<br />
<p>On October 19th, 2012, 10:45 p.m., Michael Zanetti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Michael Zanetti.</div>
<p style="color: grey;"><i>Updated Oct. 19, 2012, 10:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some more fixes for Retina screen. Because the font scales with the DPI it doesn't fit any more on the hardcoded button sizes. Here are example screenshots:
http://notyetthere.org/data/kde/nm-fixed-sizes.png
http://notyetthere.org/data/kde/nm-dynamic-sizes.png</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applet/activatableitem.cpp <span style="color: grey">(1198fd2)</span></li>
<li>applet/interfacedetailswidget.cpp <span style="color: grey">(9635559)</span></li>
<li>applet/interfaceitem.cpp <span style="color: grey">(356c285)</span></li>
<li>applet/nmpopup.cpp <span style="color: grey">(a8dfd54)</span></li>
<li>applet/wirelessinterfaceitem.cpp <span style="color: grey">(8f71b20)</span></li>
<li>applet/wirelessnetworkitem.cpp <span style="color: grey">(6489f5d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106961/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>