Review Request: Import/Export Routes for VPN connections

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104141/#review11104
-----------------------------------------------------------



libs/ui/vpnpreferences.cpp
<http://git.reviewboard.kde.org/r/104141/#comment8965>

    It's ok now.
    
    I tried to test the patch but it seem NetworkManager is refusing to accept the route configuration from Plasma NM. That is not the fault of your patch but I cannot add new routes to test your patch.
    
    The message "NetworkManager[9513]: nm_ip4_route_set_prefix: assertion `prefix <= 32' failed" appears in the log when I try to add new routes (for examploe 192.168.2.0/255.255.255.0 through gateway 192.168.1.1). 255.255.255.0 == prefix 0 and 0 is < 32, I do not know why this is happening. It would be better if the error messages printed the wrong prefix, but whatever.
    
    I will have to fix that problem first before I can test your patch.


- Lamarque Vieira Souza


On March 3, 2012, 1:43 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104141/
> -----------------------------------------------------------
> 
> (Updated March 3, 2012, 1:43 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Description
> -------
> 
> Import/Export Routes setting for VPN connections from/to configuration files. Please review the Gateway/Metrics part in particular.
> 
> 
> Diffs
> -----
> 
>   libs/ui/vpnpreferences.cpp 9afc6f2 
>   settings/config/manageconnectionwidget.cpp caa2e06 
>   vpnplugins/vpnc/CMakeLists.txt 5af39b9 
>   vpnplugins/vpnc/vpnc.cpp 79f62ec 
> 
> Diff: http://git.reviewboard.kde.org/r/104141/diff/
> 
> 
> Testing
> -------
> 
> Tested the import/export part, Routes appear properly in the new connection. I don't have a real configuration file to test :-/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120303/cbe0148f/attachment.html>