Review Request: Import/Export Routes for VPN connections

[Rajeesh K Nambiar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104141/
-----------------------------------------------------------

(Updated March 3, 2012, 1:43 p.m.)


Review request for Network Management.


Changes
-------

Please review the bool conversion for setNeverDefault method. All other review comments are addressed.


Description
-------

Import/Export Routes setting for VPN connections from/to configuration files. Please review the Gateway/Metrics part in particular.


Diffs (updated)
-----

  libs/ui/vpnpreferences.cpp 9afc6f2 
  settings/config/manageconnectionwidget.cpp caa2e06 
  vpnplugins/vpnc/CMakeLists.txt 5af39b9 
  vpnplugins/vpnc/vpnc.cpp 79f62ec 

Diff: http://git.reviewboard.kde.org/r/104141/diff/


Testing
-------

Tested the import/export part, Routes appear properly in the new connection. I don't have a real configuration file to test :-/


Thanks,

Rajeesh K Nambiar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120303/174ef504/attachment-0001.html>