Review Request: Remove licence-incompatible OpenSSL usage from OpenConnect support

[David Woodhouse]

> On June 14, 2012, 2:07 p.m., Lamarque Vieira Souza wrote:
> > Ship It!

Thanks for the review. I'm not quite sure how to interpret the "Ship it!"... I don't have commit privs so if you could commit the patch or pull it from git://git.infradead.org/users/dwmw2/networkmanagement.git (or tell me what I need to do next) that would be much appreciated. (The repo has the same patch in both master and nm09 branches, and can be browsed by s/git/http/ in the URL)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105185/#review14738
-----------------------------------------------------------


On June 9, 2012, 8:41 a.m., David Woodhouse wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105185/
> -----------------------------------------------------------
> 
> (Updated June 9, 2012, 8:41 a.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Description
> -------
> 
>     OpenConnect: Eliminate OpenSSL dependencies, support new libopenconnect
>     
>     Making libopenconnect support GnuTLS, required for licence compatibility
>     with KDE, means retrospectively changing the ABI so that the certificate
>     is treated as an opaque pointer. The library now provides a get_details()
>     method to get the certificate information in text form, so use that instead
>     of "knowing" that it's an OpenSSL X509 structure.
>     
>     Cope with a couple of other minor API changes which the change of soname
>     gave us the opportunity to introduce.
> 
> 
> Diffs
> -----
> 
>   vpnplugins/openconnect/CMakeLists.txt 3ea15bd5b343b05ac20eb2e94f012d4a14848a25 
>   vpnplugins/openconnect/openconnectauth.h 417bd7eb3898011243e320b5ec095fcfc89db596 
>   vpnplugins/openconnect/openconnectauth.cpp cd9504b0bd100d37fe3c7d09463893f966986239 
>   vpnplugins/openconnect/openconnectauthworkerthread.h 7aa8dfc866a9ea554329c4b3d14a116da74fc0ea 
>   vpnplugins/openconnect/openconnectauthworkerthread.cpp ec93ab2ca2481b8c2d58450a041414b75a1c8f6a 
> 
> Diff: http://git.reviewboard.kde.org/r/105185/diff/
> 
> 
> Testing
> -------
> 
> Building against both old and new libopenconnect, ensuring that OpenSSL is not linked directly when building against new.
> 
> Connecting to VPN from KDE with new libopenconnect (linked against GnuTLS).
> 
> 
> Thanks,
> 
> David Woodhouse
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120615/4e417e25/attachment.html>