<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105185/">http://git.reviewboard.kde.org/r/105185/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 14th, 2012, 2:07 p.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the review. I'm not quite sure how to interpret the "Ship it!"... I don't have commit privs so if you could commit the patch or pull it from git://git.infradead.org/users/dwmw2/networkmanagement.git (or tell me what I need to do next) that would be much appreciated. (The repo has the same patch in both master and nm09 branches, and can be browsed by s/git/http/ in the URL)</pre>
<br />
<p>- David</p>
<br />
<p>On June 9th, 2012, 8:41 a.m., David Woodhouse wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By David Woodhouse.</div>
<p style="color: grey;"><i>Updated June 9, 2012, 8:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> OpenConnect: Eliminate OpenSSL dependencies, support new libopenconnect
Making libopenconnect support GnuTLS, required for licence compatibility
with KDE, means retrospectively changing the ABI so that the certificate
is treated as an opaque pointer. The library now provides a get_details()
method to get the certificate information in text form, so use that instead
of "knowing" that it's an OpenSSL X509 structure.
Cope with a couple of other minor API changes which the change of soname
gave us the opportunity to introduce.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Building against both old and new libopenconnect, ensuring that OpenSSL is not linked directly when building against new.
Connecting to VPN from KDE with new libopenconnect (linked against GnuTLS).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>vpnplugins/openconnect/CMakeLists.txt <span style="color: grey">(3ea15bd5b343b05ac20eb2e94f012d4a14848a25)</span></li>
<li>vpnplugins/openconnect/openconnectauth.h <span style="color: grey">(417bd7eb3898011243e320b5ec095fcfc89db596)</span></li>
<li>vpnplugins/openconnect/openconnectauth.cpp <span style="color: grey">(cd9504b0bd100d37fe3c7d09463893f966986239)</span></li>
<li>vpnplugins/openconnect/openconnectauthworkerthread.h <span style="color: grey">(7aa8dfc866a9ea554329c4b3d14a116da74fc0ea)</span></li>
<li>vpnplugins/openconnect/openconnectauthworkerthread.cpp <span style="color: grey">(ec93ab2ca2481b8c2d58450a041414b75a1c8f6a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105185/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>