Review Request: Enable/Disable OK button when prompting user for secretes, and fix WEP key validator

[Rajeesh K Nambiar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103950/
-----------------------------------------------------------

(Updated Feb. 12, 2012, 3:05 p.m.)


Review request for Network Management.


Changes
-------

Fixed the constant qualifiers.
Thanks for the review!


Description
-------

Two fixes:
1. Fix the WEP key validator in WepAuthWidget
2. Enable/disable OK button in ConnectionSecretsJob::doAskUser


Diffs (updated)
-----

  libs/ui/connectionsecretsjob.cpp d87c47c 
  libs/ui/security/wepauthwidget.h 6ff721b 
  libs/ui/security/wepauthwidget.cpp 86b9711 
  libs/ui/security/wirelesssecurityauth.cpp 1ebefba 

Diff: http://git.reviewboard.kde.org/r/103950/diff/


Testing
-------

For change 2, WEP case is tested and working fine. WPA/WPA2 personal case is lightly tested and doesn't seem to introduce any regression. It would be great if anyone can test other encryption types.


Thanks,

Rajeesh K Nambiar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120212/5ecd5f6b/attachment.html>