Review Request: Enable/Disable OK button when prompting user for secretes, and fix WEP key validator

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103950/#review10544
-----------------------------------------------------------



libs/ui/security/wepauthwidget.h
<http://git.reviewboard.kde.org/r/103950/#comment8619>

    use "const QString &". Just keep in mind that you do not use "const" or "&" when connecting a signal to this slot. For example, the line "connect(d->settingWidget, SIGNAL(valid(bool)), SLOT(validate()));" below is correct, do not change it.



libs/ui/security/wepauthwidget.cpp
<http://git.reviewboard.kde.org/r/103950/#comment8620>

    const QString & key


- Lamarque Vieira Souza


On Feb. 12, 2012, 1:33 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103950/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2012, 1:33 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Description
> -------
> 
> Two fixes:
> 1. Fix the WEP key validator in WepAuthWidget
> 2. Enable/disable OK button in ConnectionSecretsJob::doAskUser
> 
> 
> Diffs
> -----
> 
>   libs/ui/connectionsecretsjob.cpp d87c47c 
>   libs/ui/security/wepauthwidget.h 6ff721b 
>   libs/ui/security/wepauthwidget.cpp 86b9711 
>   libs/ui/security/wirelesssecurityauth.cpp 1ebefba 
> 
> Diff: http://git.reviewboard.kde.org/r/103950/diff/
> 
> 
> Testing
> -------
> 
> For change 2, WEP case is tested and working fine. WPA/WPA2 personal case is lightly tested and doesn't seem to introduce any regression. It would be great if anyone can test other encryption types.
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120212/8863f00b/attachment.html>