Review Request: Fix to handle long connection names

Sudhendu Roy roythecooldude at gmail.com
Tue Jan 11 15:56:47 CET 2011


Yes I have a kde-developer account. But networkmanagement is on git now. So,
do i have to just "git push" it or something else?

Thanks & Regards

Sudhendu Kumar

http://www.sudhendu.in



On Tue, Jan 11, 2011 at 3:45 PM, Sebastian Kügler <sebas at kde.org> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100284/
>
> Ship it!
>
> Looks correct, thanks! Please commit (do you have an SVN account?)
>
>
> - Sebastian
>
> On January 2nd, 2011, 9:04 a.m., Sudhendu Kumar wrote:
>    Review request for Network Management.
> By Sudhendu Kumar.
>
> *Updated Jan. 2, 2011, 9:04 a.m.*
>  Description
>
> This patch is to restrict the connection name label in the networkmanagement, which earlier used to extend outside the layout.
> Also corrected two typos.
>
> Testing
>
> Tested for long connection names. Works fine on trunk.
>
> *Bugs: *255508 <http://bugs.kde.org/show_bug.cgi?id=255508>
> Diffs
>
>    - applet/interfaceitem.cpp (2667235)
>    - applet/nmpopup.cpp (970d1c6)
>
> View Diff <http://git.reviewboard.kde.org/r/100284/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110111/7308e67d/attachment.htm 


More information about the kde-networkmanager mailing list