Review Request: Fix to handle long connection names

Sebastian Kügler sebas at kde.org
Tue Jan 11 11:15:16 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100284/#review833
-----------------------------------------------------------

Ship it!


Looks correct, thanks! Please commit (do you have an SVN account?)

- Sebastian


On Jan. 2, 2011, 9:04 a.m., Sudhendu Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100284/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2011, 9:04 a.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Summary
> -------
> 
> This patch is to restrict the connection name label in the networkmanagement, which earlier used to extend outside the layout.
> Also corrected two typos.
> 
> 
> This addresses bug 255508.
>     http://bugs.kde.org/show_bug.cgi?id=255508
> 
> 
> Diffs
> -----
> 
>   applet/interfaceitem.cpp 2667235 
>   applet/nmpopup.cpp 970d1c6 
> 
> Diff: http://git.reviewboard.kde.org/r/100284/diff
> 
> 
> Testing
> -------
> 
> Tested for long connection names. Works fine on trunk.
> 
> 
> Thanks,
> 
> Sudhendu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110111/2a77dea8/attachment.htm 


More information about the kde-networkmanager mailing list