Review Request: [RFC] Import VPN connection

Lamarque Vieira Souza lamarque at gmail.com
Thu Aug 4 12:49:50 UTC 2011


Em Thursday 04 August 2011, Gökçen Eraslan escreveu:
> Pazar 22 Mayıs 2011 günü (saat 16:30:36) Rajeesh K Nambiar şunları yazmıştı:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/101419/
> > -----------------------------------------------------------
> > 
> > Review request for Network Management.
> 
> In ManageConnectionWidget::tabChanged method, that patch adds those lines:
> 
> connect(mConnEditUi.buttonSetVpn->importButton(),SIGNAL(clicked()),SLOT(imp
> ortClicked()));
> connect(mConnEditUi.buttonSetVpn->exportButton(),SIGNAL(clicked()),SLOT(ex
> portClicked()));
> 
> so every time we switch to VPN tab, another connection is
> established for clicked() signal. As a result; after a
> few tab changes, several Import dialogs appear one after another
> when the Import button of VPN is clicked.
> 
> I'll commit attached patch, if everyone is OK.

	Yes, it is Ok. I already applied this patch to nm09 branch but forgot to 
do it for master branch.

-- 
Lamarque V. Souza
http://www.geographicguide.com/brazil.htm
Linux User #57137 - http://counter.li.org/
http://planetkde.org/pt-br
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110804/869227f2/attachment.html>


More information about the kde-networkmanager mailing list