Review Request: [RFC] Import VPN connection

Gökçen Eraslan gokcen at pardus.org.tr
Thu Aug 4 09:58:56 UTC 2011


Pazar 22 Mayıs 2011 günü (saat 16:30:36) Rajeesh K Nambiar şunları yazmıştı:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101419/
> -----------------------------------------------------------
> 
> Review request for Network Management.
>

In ManageConnectionWidget::tabChanged method, that patch adds those lines:

connect(mConnEditUi.buttonSetVpn->importButton(),SIGNAL(clicked()),SLOT(importClicked()));
connect(mConnEditUi.buttonSetVpn->exportButton(),SIGNAL(clicked()),SLOT(exportClicked()));
 
so every time we switch to VPN tab, another connection is 
established for clicked() signal. As a result; after a 
few tab changes, several Import dialogs appear one after another
when the Import button of VPN is clicked.

I'll commit attached patch, if everyone is OK.

-- 
Gökçen Eraslan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: connect-import-export-buttons-once.diff
Type: text/x-patch
Size: 1311 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110804/db38e9a2/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110804/db38e9a2/attachment.sig>


More information about the kde-networkmanager mailing list