Review Request: Add BluetoothInterface class to Solid's NetworkManager backend

Lamarque Vieira Souza lamarque at gmail.com
Sun Apr 24 09:49:12 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101172/
-----------------------------------------------------------

(Updated April 24, 2011, 7:49 a.m.)


Review request for Network Management.


Changes
-------

Patch against KDE Workspace 4.6.2 to anyone whoe wants to try tethering. Be warned that you have to recompile kdelibs or kded4 may crash.


Summary (updated)
-------

This patch is the first step to implement tethering in Plasma NM. 

Tethering is term used to describe the use of a bluetooth device as the mean to access the Internet. There are two types of Bluetooth networks in tethering: DUN (Dial up Network) and PAN (Personnal Area Network). Both are very similar from Plasma NM point of view. In DUN you can use the bluetooth device (usually a cell phone) as a dial up modem (/dev/rfcomm0).

The patch slightly changes GsmNetworkInterface class to let BluetoothInterface inherit from it.


This addresses bugs 203584, 209624 and 261191.
    http://bugs.kde.org/show_bug.cgi?id=203584
    http://bugs.kde.org/show_bug.cgi?id=209624
    http://bugs.kde.org/show_bug.cgi?id=261191


Diffs (updated)
-----

  libs/solid/control/CMakeLists.txt 672ddf3 
  libs/solid/control/backends/fakenet/fakenetworkinterface.h dd90ab6 
  libs/solid/control/backends/fakenet/fakenetworkinterface.cpp 3e0a3a9 
  libs/solid/control/ifaces/CMakeLists.txt 6dada2b 
  libs/solid/control/ifaces/networkbtinterface.h PRE-CREATION 
  libs/solid/control/ifaces/networkbtinterface.cpp PRE-CREATION 
  libs/solid/control/ifaces/networkinterface.h 0131920 
  libs/solid/control/networkbtinterface.h PRE-CREATION 
  libs/solid/control/networkbtinterface.cpp PRE-CREATION 
  libs/solid/control/networkbtinterface_p.h PRE-CREATION 
  libs/solid/control/networkinterface.h c1476cd 
  libs/solid/control/networkmanager.cpp 5a213e9 
  solid/networkmanager-0.7/CMakeLists.txt cc33466 
  solid/networkmanager-0.7/dbus/introspection/nm-device-bt.xml b1716b3 
  solid/networkmanager-0.7/dbus/introspection/nm-device.xml 952f1cf 
  solid/networkmanager-0.7/dbus/nm-device-btinterface.h PRE-CREATION 
  solid/networkmanager-0.7/dbus/nm-device-btinterface.cpp PRE-CREATION 
  solid/networkmanager-0.7/dbus/nm-deviceinterface.h c7456f9 
  solid/networkmanager-0.7/dbus/nm-deviceinterface.cpp ac88d27 
  solid/networkmanager-0.7/manager.cpp 1f67806 
  solid/networkmanager-0.7/networkbtinterface.h PRE-CREATION 
  solid/networkmanager-0.7/networkbtinterface.cpp PRE-CREATION 
  solid/networkmanager-0.7/networkbtinterface_p.h PRE-CREATION 
  solid/networkmanager-0.7/networkgsminterface.h 64b9477 
  solid/networkmanager-0.7/networkgsminterface.cpp 3b16c3c 
  solid/networkmanager-0.7/networkinterface.h 781c76d 
  solid/networkmanager-0.7/networkinterface.cpp ab73fc9 
  solid/networkmanager-0.7/networkinterface_p.h 6dba9a1 
  solid/wicd/networkinterface.h 0259e89 
  solid/wicd/networkinterface.cpp 403b03c 

Diff: http://git.reviewboard.kde.org/r/101172/diff


Testing (updated)
-------

Tested against KDE SC 4.6.2, works with Gsm phones. Support to Cdma phones still missing.


Thanks,

Lamarque Vieira

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110424/eb411206/attachment.htm 


More information about the kde-networkmanager mailing list