<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101172/">http://git.reviewboard.kde.org/r/101172/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Lamarque Vieira Souza.</div>
<p style="color: grey;"><i>Updated April 24, 2011, 7:49 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch against KDE Workspace 4.6.2 to anyone whoe wants to try tethering. Be warned that you have to recompile kdelibs or kded4 may crash.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is the first step to implement tethering in Plasma NM.
Tethering is term used to describe the use of a bluetooth device as the mean to access the Internet. There are two types of Bluetooth networks in tethering: DUN (Dial up Network) and PAN (Personnal Area Network). Both are very similar from Plasma NM point of view. In DUN you can use the bluetooth device (usually a cell phone) as a dial up modem (/dev/rfcomm0).
The patch slightly changes GsmNetworkInterface class to let BluetoothInterface inherit from it.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested against KDE SC 4.6.2, works with Gsm phones. Support to Cdma phones still missing.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=203584">203584</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=209624">209624</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=261191">261191</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/solid/control/CMakeLists.txt <span style="color: grey">(672ddf3)</span></li>
<li>libs/solid/control/backends/fakenet/fakenetworkinterface.h <span style="color: grey">(dd90ab6)</span></li>
<li>libs/solid/control/backends/fakenet/fakenetworkinterface.cpp <span style="color: grey">(3e0a3a9)</span></li>
<li>libs/solid/control/ifaces/CMakeLists.txt <span style="color: grey">(6dada2b)</span></li>
<li>libs/solid/control/ifaces/networkbtinterface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/solid/control/ifaces/networkbtinterface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/solid/control/ifaces/networkinterface.h <span style="color: grey">(0131920)</span></li>
<li>libs/solid/control/networkbtinterface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/solid/control/networkbtinterface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/solid/control/networkbtinterface_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/solid/control/networkinterface.h <span style="color: grey">(c1476cd)</span></li>
<li>libs/solid/control/networkmanager.cpp <span style="color: grey">(5a213e9)</span></li>
<li>solid/networkmanager-0.7/CMakeLists.txt <span style="color: grey">(cc33466)</span></li>
<li>solid/networkmanager-0.7/dbus/introspection/nm-device-bt.xml <span style="color: grey">(b1716b3)</span></li>
<li>solid/networkmanager-0.7/dbus/introspection/nm-device.xml <span style="color: grey">(952f1cf)</span></li>
<li>solid/networkmanager-0.7/dbus/nm-device-btinterface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/networkmanager-0.7/dbus/nm-device-btinterface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/networkmanager-0.7/dbus/nm-deviceinterface.h <span style="color: grey">(c7456f9)</span></li>
<li>solid/networkmanager-0.7/dbus/nm-deviceinterface.cpp <span style="color: grey">(ac88d27)</span></li>
<li>solid/networkmanager-0.7/manager.cpp <span style="color: grey">(1f67806)</span></li>
<li>solid/networkmanager-0.7/networkbtinterface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/networkmanager-0.7/networkbtinterface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/networkmanager-0.7/networkbtinterface_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/networkmanager-0.7/networkgsminterface.h <span style="color: grey">(64b9477)</span></li>
<li>solid/networkmanager-0.7/networkgsminterface.cpp <span style="color: grey">(3b16c3c)</span></li>
<li>solid/networkmanager-0.7/networkinterface.h <span style="color: grey">(781c76d)</span></li>
<li>solid/networkmanager-0.7/networkinterface.cpp <span style="color: grey">(ab73fc9)</span></li>
<li>solid/networkmanager-0.7/networkinterface_p.h <span style="color: grey">(6dba9a1)</span></li>
<li>solid/wicd/networkinterface.h <span style="color: grey">(0259e89)</span></li>
<li>solid/wicd/networkinterface.cpp <span style="color: grey">(403b03c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101172/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>