Request to review my patch to solid

[Lamarque Vieira Souza]

Em Sexta-feira 30 Abril 2010, Will Stephenson escreveu:
> On Thursday 22 April 2010 23:03:30 Lamarque Vieira Souza wrote:
> > 	Hi all,
> > 	
> > 	I am new to the list, but I am in other KDE lists for quite some time. I
> > 
> > would like you to review this patch that adds preliminary ModemManager
> > support to solid:
> > 
> > http://reviewboard.kde.org/r/3769/
> > 
> > 	This patch is a dependency for this other patch
> > 
> > http://reviewboard.kde.org/r/3778/ to knetworkmanager. I plan to
> > implement other things in knetworkmanager but I need the first patch
> > applied first so I can add other things later. I also need some advice
> > as to how solve the problems I described in
> > http://reviewboard.kde.org/r/3769/.
> 
> Hi Lamarque
> 
> I will review your patches ASAP but I am moving house and am without an
> internet connection at home currently.  It will be the middle of next week
> I think.
> 
> Thanks for taking this on!
> 
> Will

	Actually I did some changes in them and finally solved the problem with 
NetworkManager and ModemManager having different device lists. I am going to 
do one more changes in them and I will update them in reviewboard tomorrow. 
Basicaly the patch for solid implements ModemManager support and the patch for 
knetworkmanager adds a tab in the monolithic version to show information about 
the gsm network (name and quality for now). I plan to add more ModemManager 
dbus calls, not all of them work with my modem so I cannot test all of them.

	By the way, I have changed one of your changes in monolithic version. The 
nameserver IP addresses were in reverse byte order in 
connectioninfoipv4tab.cpp, adding ntohl solved this. Only after commiting the 
change to svn I noticed in the log you removed ntohl before SC 4.4.0 release, 
but it is still used in tooltipbuilder.cpp.

-- 
Lamarque V. Souza
http://www.geographicguide.com/brazil.htm
Linux User #57137 - http://counter.li.org/
http://www.kde-mg.org