Review Request 130112: [kmix] Minor porting stuff

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130112/#review103167
-----------------------------------------------------------



Please keep osdwidget, it should be investigated more. It was disabled from the KF5 version here:
https://commits.kde.org/kmix/69aa3baf266b5e0952737dd203d7d2735e6d374b
and the commit message shows that "requires porting".

I understand that the code which was using it was removed in the merges, probably also by me, but that was a mistake.

- Luigi Toscano


On Mag. 1, 2017, 4:11 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130112/
> -----------------------------------------------------------
> 
> (Updated Mag. 1, 2017, 4:11 p.m.)
> 
> 
> Review request for KDE Multimedia and Luigi Toscano.
> 
> 
> Repository: kmix
> 
> 
> Description
> -------
> 
> - Add missing dependencies
> - Install doc the ECM way
> - Remove unused gui/osdwidget.{cpp,h}
> - Fix ecm_install_icons warnings
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 107e7fd236e32ef8e9800c6da55615463bb0bf07 
>   doc/CMakeLists.txt 7ce5542158ceeb76e4aea7f0f21e5d85ff5139a3 
>   gui/osdwidget.h 3e80cd629e5d8d88c393a9d67303dcc5eafcbbb0 
>   gui/osdwidget.cpp e3e8418b3509a1426bb256241f7b0ce770919e92 
>   pics/CMakeLists.txt ca12602b79315f79bc25359fee5ba39aa98d07f3 
>   pics/hi128-app-kmix.png  
>   pics/hi16-app-kmix.png  
>   pics/hi32-app-kmix.png  
>   pics/hi48-app-kmix.png  
>   pics/hi64-app-kmix.png  
> 
> Diff: https://git.reviewboard.kde.org/r/130112/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20170501/bfc7fbfd/attachment.htm>