<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130112/">https://git.reviewboard.kde.org/r/130112/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please keep osdwidget, it should be investigated more. It was disabled from the KF5 version here:
https://commits.kde.org/kmix/69aa3baf266b5e0952737dd203d7d2735e6d374b
and the commit message shows that "requires porting".
I understand that the code which was using it was removed in the merges, probably also by me, but that was a mistake.</pre>
<br />
<p>- Luigi Toscano</p>
<br />
<p>On maggio 1st, 2017, 4:11 p.m. CEST, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia and Luigi Toscano.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated Mag. 1, 2017, 4:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmix
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Add missing dependencies</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Install doc the ECM way</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Remove unused gui/osdwidget.{cpp,h}</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Fix ecm_install_icons warnings</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(107e7fd236e32ef8e9800c6da55615463bb0bf07)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(7ce5542158ceeb76e4aea7f0f21e5d85ff5139a3)</span></li>
<li>gui/osdwidget.h <span style="color: grey">(3e80cd629e5d8d88c393a9d67303dcc5eafcbbb0)</span></li>
<li>gui/osdwidget.cpp <span style="color: grey">(e3e8418b3509a1426bb256241f7b0ce770919e92)</span></li>
<li>pics/CMakeLists.txt <span style="color: grey">(ca12602b79315f79bc25359fee5ba39aa98d07f3)</span></li>
<li>pics/hi128-app-kmix.png <span style="color: grey">()</span></li>
<li>pics/hi16-app-kmix.png <span style="color: grey">()</span></li>
<li>pics/hi32-app-kmix.png <span style="color: grey">()</span></li>
<li>pics/hi48-app-kmix.png <span style="color: grey">()</span></li>
<li>pics/hi64-app-kmix.png <span style="color: grey">()</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130112/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>