Review Request 129923: [ffmpegthumbs] Remove the 1px border from thumbnails

[Diego Soenens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129923/
-----------------------------------------------------------

(Updated March 27, 2017, 10:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Multimedia.


Changes
-------

Submitted with commit bb2944b120ebf618a6e2fc5bec448127de441b04 by Albert Astals Cid on behalf of Diego Soenens to branch Applications/17.04.


Repository: ffmpegthumbs


Description
-------

This is part of https://git.reviewboard.kde.org/r/129921/.

Returning DrawFrame in flags results in a 1px black and white border getting added to the thumbnail while returning None does not.
There is no reason why it should be adding a border.
Especially since this thumbnail creator generates images that could (and should IMO) be treated the same as thumbnails from, say, image files like wallpapers etc.


Diffs
-----

  ffmpegthumbnailer.cpp e8604e417979fecf9af5edda67cf8f1dbfc0f13c 

Diff: https://git.reviewboard.kde.org/r/129923/diff/


Testing
-------


Thanks,

Diego Soenens

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20170327/572fc361/attachment.htm>