Review Request 130165: Why different tocs failed to refresh template titles?

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130165/#review103354
-----------------------------------------------------------



Mh, that seems to just replace one problem (incorrect track count) with another problem (re-generation on every URL change). https://cgit.kde.org/audiocd-kio.git/commit/?id=555c028b2a654ca6012494bd1ad666a3dbd68a9c was where the toc diffing was implemented and the defect described in the bug report sounds a bit like what Albert described in the commit message.

Unless Albert has some immediately better input on this I suggest you take this back to the bug report and figure out if the bug is really that the data isn't refreshed on a slave level or dolphin simply fails to display the refreshed information.

>From just reading `tocsAreDifferent` I find it hard to imagine one CD being *that* similar to another one without being the same one.

- Harald Sitter


On June 21, 2017, 2:30 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130165/
> -----------------------------------------------------------
> 
> (Updated June 21, 2017, 2:30 a.m.)
> 
> 
> Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, Harald Sitter, and Xuetian Weng.
> 
> 
> Bugs: 381038
>     http://bugs.kde.org/show_bug.cgi?id=381038
> 
> 
> Repository: audiocd-kio
> 
> 
> Description
> -------
> 
> Dear,
> 
> As pietz described in the bugzilla, audiocd kio slave failed to refresh template titles, so dolphin shows still the number of files from the first CD in the drive, not update the template titles.
> 
> I do not have different CDs right now in my office, but I will borrow some "Music Together" CDs from my little kid :) but I directly read the source code for debugging, although workaround patch is let `tocsAreDifferent` always return true to refresh in force, but what the root cause is? please give me some hints, thanks a lot!
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -----
> 
>   audiocd.cpp 926308d 
> 
> Diff: https://git.reviewboard.kde.org/r/130165/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20170621/a401ca16/attachment.htm>