<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130165/">https://git.reviewboard.kde.org/r/130165/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Mh, that seems to just replace one problem (incorrect track count) with another problem (re-generation on every URL change). https://cgit.kde.org/audiocd-kio.git/commit/?id=555c028b2a654ca6012494bd1ad666a3dbd68a9c was where the toc diffing was implemented and the defect described in the bug report sounds a bit like what Albert described in the commit message.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unless Albert has some immediately better input on this I suggest you take this back to the bug report and figure out if the bug is really that the data isn't refreshed on a slave level or dolphin simply fails to display the refreshed information.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">From just reading <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">tocsAreDifferent</code> I find it hard to imagine one CD being <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">that</em> similar to another one without being the same one.</p></pre>
<br />
<p>- Harald Sitter</p>
<br />
<p>On June 21st, 2017, 2:30 a.m. UTC, Leslie Zhai wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, Harald Sitter, and Xuetian Weng.</div>
<div>By Leslie Zhai.</div>
<p style="color: grey;"><i>Updated June 21, 2017, 2:30 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=381038">381038</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
audiocd-kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Dear,</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As pietz described in the bugzilla, audiocd kio slave failed to refresh template titles, so dolphin shows still the number of files from the first CD in the drive, not update the template titles.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I do not have different CDs right now in my office, but I will borrow some "Music Together" CDs from my little kid :) but I directly read the source code for debugging, although workaround patch is let <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">tocsAreDifferent</code> always return true to refresh in force, but what the root cause is? please give me some hints, thanks a lot!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regards,
Leslie Zhai</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>audiocd.cpp <span style="color: grey">(926308d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130165/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>