Review Request 130212: Fix confused by the different with QTemporaryDir and QDir issue

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130212/#review103523
-----------------------------------------------------------



Please use phabricator, reviewboard is deprecated and getting killed at some point https://community.kde.org/Infrastructure/Phabricator

- Harald Sitter


On Aug. 2, 2017, 4:51 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130212/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2017, 4:51 a.m.)
> 
> 
> Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, and Harald Sitter.
> 
> 
> Bugs: 383011
>     http://bugs.kde.org/show_bug.cgi?id=383011
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> Hi KDE developers,
> 
> tempDir was defined as `QScopedPointer<QTemporaryDir>` https://github.com/KDE/k3b/commit/05cd636c9dfb35fdeea666b581c1f2b9c3820a90#diff-920d85bf84619674590c2e13a0428d00R40 it is easy to create a unique directory for temporary use, and QScopedPointer's destructor will free the allocated memory automatically, brain-free :)
> 
> but it still mkdir all parenets directories in complicated way https://github.com/KDE/k3b/commit/05cd636c9dfb35fdeea666b581c1f2b9c3820a90#diff-920d85bf84619674590c2e13a0428d00R113
> 
> so I just mkpath for temporary `VIDEO_TS` directory and provide correct temporary path, such as `/tmp/k3bVideoDvdfINBwV` to genisoimage, please review my patch, and give me some suggestion, thanks a lot!
> 
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -----
> 
>   libk3b/projects/videodvd/k3bvideodvdimager.cpp a8ae69a 
> 
> Diff: https://git.reviewboard.kde.org/r/130212/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20170802/84f52c03/attachment.htm>