Review Request 127196: Migrate to musicbrainz5

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127196/#review96057
-----------------------------------------------------------




mbmanager.cpp (line 128)
<https://git.reviewboard.kde.org/r/127196/#comment64973>

    can discArtist be const? same for other stuff in the previous/next functions that gets passed by reference


- Albert Astals Cid


On Feb. 27, 2016, 8:01 a.m., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127196/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2016, 8:01 a.m.)
> 
> 
> Review request for KDE Multimedia and Torrie Fischer.
> 
> 
> Repository: kscd
> 
> 
> Description
> -------
> 
> Migrate to musicbrainz5
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e8915067529df072ecde3a0bb5e54a870cd2621a 
>   cmake/FindDiscId.cmake PRE-CREATION 
>   cmake/FindMusicBrainz5.cmake PRE-CREATION 
>   kscd.h dcbdd57b1f5f18dc369ea8babd66fc4340553b31 
>   kscd.cpp 3bcb8f664fa76143f33ef69cd28fa7116ee475ea 
>   mbmanager.h 6b07e951adf12a34e4c946367b2708c73dd59fcf 
>   mbmanager.cpp 4df3803afb13c788b9e0c0d49dbe7c20f00f3fd6 
> 
> Diff: https://git.reviewboard.kde.org/r/127196/diff/
> 
> 
> Testing
> -------
> 
> It works for me, but the musicbrainz services reply 503 often.
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160530/70efe2d4/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia