Review Request 127196: Migrate to musicbrainz5
Wolfgang Bauer
wbauer at tmo.at
Mon May 30 19:53:24 BST 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127196/#review96050
-----------------------------------------------------------
Works fine here.
Regarding the 503 errors, I suppose that's a problem on their side.
I do get them with the old version using libmusicbrainz3 as well, so I think that's unrelated to this patch.
I'm not in the position to give a ShipIt though, I hope somebody else replies too...
- Wolfgang Bauer
On Feb. 27, 2016, 9:01 vorm., Maximiliano Curia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127196/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 9:01 vorm.)
>
>
> Review request for KDE Multimedia and Torrie Fischer.
>
>
> Repository: kscd
>
>
> Description
> -------
>
> Migrate to musicbrainz5
>
>
> Diffs
> -----
>
> CMakeLists.txt e8915067529df072ecde3a0bb5e54a870cd2621a
> cmake/FindDiscId.cmake PRE-CREATION
> cmake/FindMusicBrainz5.cmake PRE-CREATION
> kscd.h dcbdd57b1f5f18dc369ea8babd66fc4340553b31
> kscd.cpp 3bcb8f664fa76143f33ef69cd28fa7116ee475ea
> mbmanager.h 6b07e951adf12a34e4c946367b2708c73dd59fcf
> mbmanager.cpp 4df3803afb13c788b9e0c0d49dbe7c20f00f3fd6
>
> Diff: https://git.reviewboard.kde.org/r/127196/diff/
>
>
> Testing
> -------
>
> It works for me, but the musicbrainz services reply 503 often.
>
>
> Thanks,
>
> Maximiliano Curia
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160530/d72124ec/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
More information about the kde-multimedia
mailing list