Review Request 128419: Fix MPRIS2 DesktopEntry value

Antonio Rojas nqn1976 at gmail.com
Mon Jul 11 23:13:26 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128419/
-----------------------------------------------------------

(Updated July 11, 2016, 10:13 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Multimedia.


Changes
-------

Submitted with commit f3930e6d7d782d67ce16eac34acbc71e6360731e by Michael Pyne on behalf of Antonio Rojas to branch master.


Bugs: 365275
    http://bugs.kde.org/show_bug.cgi?id=365275


Repository: juk


Description
-------

According to the MPRIS2 spec, the DesktopEntry value should be "the basename of the .desktop file" [1], not the desktop-file-id. So for juk it should be "juk" and not "kde4-juk", regardless of where the desktop file is installed. This fixes displaying MPRIS controls in the juk taskbar tooltip in Plasma 5.7

[1] https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry


Diffs
-----

  mpris2/mediaplayer2.cpp 2514ac0 

Diff: https://git.reviewboard.kde.org/r/128419/diff/


Testing
-------


Thanks,

Antonio Rojas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160711/82f602f1/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list