Review Request 128419: Fix MPRIS2 DesktopEntry value
Antonio Rojas
nqn1976 at gmail.com
Sun Jul 10 20:12:06 BST 2016
> On Jul. 10, 2016, 2:53 p.m., Michael Pyne wrote:
> > LGTM. Please let me know if you're not able to make commit and I'll commit on your behalf.
Yes please, I don't have a developer account
- Antonio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128419/#review97260
-----------------------------------------------------------
On Jul. 10, 2016, 10:24 a.m., Antonio Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128419/
> -----------------------------------------------------------
>
> (Updated Jul. 10, 2016, 10:24 a.m.)
>
>
> Review request for KDE Multimedia.
>
>
> Bugs: 365275
> http://bugs.kde.org/show_bug.cgi?id=365275
>
>
> Repository: juk
>
>
> Description
> -------
>
> According to the MPRIS2 spec, the DesktopEntry value should be "the basename of the .desktop file" [1], not the desktop-file-id. So for juk it should be "juk" and not "kde4-juk", regardless of where the desktop file is installed. This fixes displaying MPRIS controls in the juk taskbar tooltip in Plasma 5.7
>
> [1] https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry
>
>
> Diffs
> -----
>
> mpris2/mediaplayer2.cpp 2514ac0
>
> Diff: https://git.reviewboard.kde.org/r/128419/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Antonio Rojas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160710/bc100adc/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
More information about the kde-multimedia
mailing list