Review Request 127732: Use KLocalizedString instead of klocale.h

Bernd Steinhauser linux at bernd-steinhauser.de
Sun Apr 24 23:42:54 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127732/
-----------------------------------------------------------

(Updated April 24, 2016, 10:42 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Multimedia.


Changes
-------

Submitted with commit eaa16c4e88d67bcf14fc112b45f4fd45045320bc by Albert Astals Cid on behalf of Bernd Steinhauser to branch frameworks.


Repository: libkcompactdisc


Description
-------

The use of klocale.h seems to be the last occurrence of kdelibs4support.
Thus use KLocalizedString and don't link to KF5::KDELibs4Support.

The only reason why it cannot be fully cleaned from that yet is that it requires FindAlsa.cmake which is part of kdelibs4support.

To do that, maybe it should be considered to remove wmlib.


Diffs
-----

  src/CMakeLists.txt f07cd05 
  src/kcompactdisc_p.cpp a39e769 
  src/phonon_interface.cpp 45f21db 
  src/wmlib_interface.cpp b26c514 

Diff: https://git.reviewboard.kde.org/r/127732/diff/


Testing
-------


Thanks,

Bernd Steinhauser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160424/91d3fae2/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list