Review Request 127732: Use KLocalizedString instead of klocale.h

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127732/#review94812
-----------------------------------------------------------


Ship it!




Ship It!

- Albert Astals Cid


On abr. 24, 2016, 6:20 p.m., Bernd Steinhauser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127732/
> -----------------------------------------------------------
> 
> (Updated abr. 24, 2016, 6:20 p.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Repository: libkcompactdisc
> 
> 
> Description
> -------
> 
> The use of klocale.h seems to be the last occurrence of kdelibs4support.
> Thus use KLocalizedString and don't link to KF5::KDELibs4Support.
> 
> The only reason why it cannot be fully cleaned from that yet is that it requires FindAlsa.cmake which is part of kdelibs4support.
> 
> To do that, maybe it should be considered to remove wmlib.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f07cd05 
>   src/kcompactdisc_p.cpp a39e769 
>   src/phonon_interface.cpp 45f21db 
>   src/wmlib_interface.cpp b26c514 
> 
> Diff: https://git.reviewboard.kde.org/r/127732/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Steinhauser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160424/dc6a4c96/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia