Review Request 125403: Search for KDELibs4Support to fix the build
Heiko Becker
heirecka at exherbo.org
Sat Sep 26 12:15:42 BST 2015
> On Sept. 26, 2015, 10:14 vorm., Boudhayan Gupta wrote:
> > Ship it for now, but eventually we'll have to find an alternative and remove it.
>
> Boudhayan Gupta wrote:
> I have removed kdemacros.h and have used CMake's generate_export_header to generate the exports. I'll copy over the FindAlsa code from KL4Support and then nuke this.
Cool, thank you!
- Heiko
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125403/#review85948
-----------------------------------------------------------
On Sept. 26, 2015, 10:19 vorm., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125403/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2015, 10:19 vorm.)
>
>
> Review request for KDE Multimedia and Boudhayan Gupta.
>
>
> Repository: libkcompactdisc
>
>
> Description
> -------
>
> kdemacros.h needs it.
>
>
> Diffs
> -----
>
> CMakeLists.txt f1e5712
> src/CMakeLists.txt 7c7d720
>
> Diff: https://git.reviewboard.kde.org/r/125403/diff/
>
>
> Testing
> -------
>
> libkcompactdisc builds and installs fine with this patch.
>
>
> Thanks,
>
> Heiko Becker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150926/14a8a405/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
More information about the kde-multimedia
mailing list