Review Request 125403: Search for KDELibs4Support to fix the build

Boudhayan Gupta bgupta at kde.org
Sat Sep 26 12:11:49 BST 2015



> On Sept. 26, 2015, 3:44 p.m., Boudhayan Gupta wrote:
> > Ship it for now, but eventually we'll have to find an alternative and remove it.

I have removed kdemacros.h and have used CMake's generate_export_header to generate the exports. I'll copy over the FindAlsa code from KL4Support and then nuke this.


- Boudhayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125403/#review85948
-----------------------------------------------------------


On Sept. 26, 2015, 3:49 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125403/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2015, 3:49 p.m.)
> 
> 
> Review request for KDE Multimedia and Boudhayan Gupta.
> 
> 
> Repository: libkcompactdisc
> 
> 
> Description
> -------
> 
> kdemacros.h needs it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f1e5712 
>   src/CMakeLists.txt 7c7d720 
> 
> Diff: https://git.reviewboard.kde.org/r/125403/diff/
> 
> 
> Testing
> -------
> 
> libkcompactdisc builds and installs fine with this patch.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150926/ed10d21e/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list