Review Request 122159: Run convert-to-cmake-automoc.pl over files

[Kevin Funk]

> On Jan. 20, 2015, 9:24 p.m., Christian Esken wrote:
> > I have read http://kfunk.org/2015/01/11/new-porting-helper-convert-to-cmake-automoc-pl/ and understand that cmake-automoc is a convenient feature. I have two questions:
> > 1) Doesn't this require to modify CMakeLists.txt
> > 2) Does this work for both KDE4 and KF5 builds? KMix can currently be built for both (-DKMIX_KF5_BUILD=1), and will remain so for a while until all KMix features are ported and stable in the KF5 build.

1: No, CMAKE_AUTOMOC set is set via CMake scripts included from KDE/ECM in under KDE4 and KF5
2: Yes, but please double-check by compiling against KDE4 (I didn't)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122159/#review74442
-----------------------------------------------------------


On Jan. 19, 2015, 11:50 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122159/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2015, 11:50 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Repository: kmix
> 
> 
> Description
> -------
> 
> Run convert-to-cmake-automoc.pl over files
> 
> 
> Diffs
> -----
> 
>   gui/mdwswitch.cpp 3a922f0bbc6c0589c7c6d7150b6d8c6a0365ecf5 
>   gui/mixdevicewidget.cpp bbc85042a6b5115ad11fff0ee58a727f0f9cf8b3 
>   gui/osdwidget.cpp 1b0047ea8afd95957415996ca8b0cabe0f40d651 
>   gui/viewbase.cpp d7ce3e9244672fd259fca56ef82bb7441e7002f0 
>   gui/viewdockareapopup.cpp 64db6ac2bf87b676a3e1c0a44db1069973c94fe2 
>   gui/viewsliders.cpp e08ec26fc31c40c38b4d18eb7af5164866613e86 
>   gui/volumeslider.cpp 1a4166e074250b460e1637ac2862283318a8c9e4 
>   plasma/engine/mixerservice.cpp 13b4fa2d822d3f9b14515155e5b136e9bda4201d 
>   tests/dialogtest.cpp cc91f72b06f616d93c18b8e6273a90d9c0d2cbd1 
>   apps/KMixApp.cpp 6c63da32e88f99f67355827648e3e87bc96d852a 
>   apps/kmix.cpp a6b8187dea412e527ec4b1e77e720aa81087d173 
>   backends/mixer_backend.cpp ac64bae0e1431d1b4a9e6385ce122ce3f52b035c 
>   backends/mixer_mpris2.cpp bffc714779a22d27c67c67819b3e8f8d27e91c7c 
>   backends/mixer_pulse.cpp bdcc797dc80452d49165634c4a0072d3430602f7 
>   core/ControlManager.cpp d181db278337d2fc9b4ef5392c20d5038df745bc 
>   core/kmixdevicemanager.cpp cd92c8e688ae000ed430a12d7c78c4fc6b508380 
>   core/mixdevice.cpp 7fce6ee201bca4b523ab76552636039e09bd2f3f 
>   gui/mdwenum.cpp ca89927935e0b86d1d306aad30821485627d928b 
>   gui/mdwslider.cpp d94aa967514793d0095713aebed0c9c2646b4c87 
>   core/mixdevicecomposite.cpp dec3a8f69c0c50384615c6765adc344b987c9d44 
>   core/mixer.cpp 504baf58a2f0e1b602b75d4f5303736f549eff81 
>   core/mixertoolbox.cpp 87154623a7c960e538cbe01c5a6be383b93ad906 
>   dbus/dbuscontrolwrapper.cpp 4971bd8245c7a604ec4e7f0cce936c4a33eab852 
>   dbus/dbusmixerwrapper.cpp d135d4209f1741ce5d678d0df11461a3a44359e9 
>   dbus/dbusmixsetwrapper.cpp 63012d7cbc1e6d416ca59535aa0b0847e6569bab 
>   gui/dialogaddview.cpp 4392e3ffe95ee535dc87dd2b8ae46900abe0c80a 
>   gui/dialogchoosebackends.cpp 66ec8e7c8404d9711360f9cee17b1b87ec2c5ca9 
>   gui/dialogselectmaster.cpp 788cdb9763f9307b3201ad48e8fe63c8528c0e37 
>   gui/dialogviewconfiguration.cpp 963627e39e28e04b430ff0b5d34ef808da9de2e9 
>   gui/kmixdockwidget.cpp eeccb3608787f82c262a49fbb835dd3f10005dad 
>   gui/kmixerwidget.cpp bbfb13be55a2911f594559ca4ac02f0bc7256acc 
>   gui/kmixprefdlg.cpp bde7b15df1ae533d88c8774d71f508307a32c0c0 
>   gui/ksmallslider.cpp a681b4fd94481a6939b0d2edd7c4d9c9216a65d3 
> 
> Diff: https://git.reviewboard.kde.org/r/122159/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150121/e928d76f/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia