<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122159/">https://git.reviewboard.kde.org/r/122159/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 20th, 2015, 9:24 p.m. UTC, <b>Christian Esken</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have read http://kfunk.org/2015/01/11/new-porting-helper-convert-to-cmake-automoc-pl/ and understand that cmake-automoc is a convenient feature. I have two questions:
1) Doesn't this require to modify CMakeLists.txt
2) Does this work for both KDE4 and KF5 builds? KMix can currently be built for both (-DKMIX_KF5_BUILD=1), and will remain so for a while until all KMix features are ported and stable in the KF5 build.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1: No, CMAKE_AUTOMOC set is set via CMake scripts included from KDE/ECM in under KDE4 and KF5
2: Yes, but please double-check by compiling against KDE4 (I didn't)</p></pre>
<br />
<p>- Kevin</p>
<br />
<p>On January 19th, 2015, 11:50 p.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia and Christian Esken.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2015, 11:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmix
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Run convert-to-cmake-automoc.pl over files</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>gui/mdwswitch.cpp <span style="color: grey">(3a922f0bbc6c0589c7c6d7150b6d8c6a0365ecf5)</span></li>
<li>gui/mixdevicewidget.cpp <span style="color: grey">(bbc85042a6b5115ad11fff0ee58a727f0f9cf8b3)</span></li>
<li>gui/osdwidget.cpp <span style="color: grey">(1b0047ea8afd95957415996ca8b0cabe0f40d651)</span></li>
<li>gui/viewbase.cpp <span style="color: grey">(d7ce3e9244672fd259fca56ef82bb7441e7002f0)</span></li>
<li>gui/viewdockareapopup.cpp <span style="color: grey">(64db6ac2bf87b676a3e1c0a44db1069973c94fe2)</span></li>
<li>gui/viewsliders.cpp <span style="color: grey">(e08ec26fc31c40c38b4d18eb7af5164866613e86)</span></li>
<li>gui/volumeslider.cpp <span style="color: grey">(1a4166e074250b460e1637ac2862283318a8c9e4)</span></li>
<li>plasma/engine/mixerservice.cpp <span style="color: grey">(13b4fa2d822d3f9b14515155e5b136e9bda4201d)</span></li>
<li>tests/dialogtest.cpp <span style="color: grey">(cc91f72b06f616d93c18b8e6273a90d9c0d2cbd1)</span></li>
<li>apps/KMixApp.cpp <span style="color: grey">(6c63da32e88f99f67355827648e3e87bc96d852a)</span></li>
<li>apps/kmix.cpp <span style="color: grey">(a6b8187dea412e527ec4b1e77e720aa81087d173)</span></li>
<li>backends/mixer_backend.cpp <span style="color: grey">(ac64bae0e1431d1b4a9e6385ce122ce3f52b035c)</span></li>
<li>backends/mixer_mpris2.cpp <span style="color: grey">(bffc714779a22d27c67c67819b3e8f8d27e91c7c)</span></li>
<li>backends/mixer_pulse.cpp <span style="color: grey">(bdcc797dc80452d49165634c4a0072d3430602f7)</span></li>
<li>core/ControlManager.cpp <span style="color: grey">(d181db278337d2fc9b4ef5392c20d5038df745bc)</span></li>
<li>core/kmixdevicemanager.cpp <span style="color: grey">(cd92c8e688ae000ed430a12d7c78c4fc6b508380)</span></li>
<li>core/mixdevice.cpp <span style="color: grey">(7fce6ee201bca4b523ab76552636039e09bd2f3f)</span></li>
<li>gui/mdwenum.cpp <span style="color: grey">(ca89927935e0b86d1d306aad30821485627d928b)</span></li>
<li>gui/mdwslider.cpp <span style="color: grey">(d94aa967514793d0095713aebed0c9c2646b4c87)</span></li>
<li>core/mixdevicecomposite.cpp <span style="color: grey">(dec3a8f69c0c50384615c6765adc344b987c9d44)</span></li>
<li>core/mixer.cpp <span style="color: grey">(504baf58a2f0e1b602b75d4f5303736f549eff81)</span></li>
<li>core/mixertoolbox.cpp <span style="color: grey">(87154623a7c960e538cbe01c5a6be383b93ad906)</span></li>
<li>dbus/dbuscontrolwrapper.cpp <span style="color: grey">(4971bd8245c7a604ec4e7f0cce936c4a33eab852)</span></li>
<li>dbus/dbusmixerwrapper.cpp <span style="color: grey">(d135d4209f1741ce5d678d0df11461a3a44359e9)</span></li>
<li>dbus/dbusmixsetwrapper.cpp <span style="color: grey">(63012d7cbc1e6d416ca59535aa0b0847e6569bab)</span></li>
<li>gui/dialogaddview.cpp <span style="color: grey">(4392e3ffe95ee535dc87dd2b8ae46900abe0c80a)</span></li>
<li>gui/dialogchoosebackends.cpp <span style="color: grey">(66ec8e7c8404d9711360f9cee17b1b87ec2c5ca9)</span></li>
<li>gui/dialogselectmaster.cpp <span style="color: grey">(788cdb9763f9307b3201ad48e8fe63c8528c0e37)</span></li>
<li>gui/dialogviewconfiguration.cpp <span style="color: grey">(963627e39e28e04b430ff0b5d34ef808da9de2e9)</span></li>
<li>gui/kmixdockwidget.cpp <span style="color: grey">(eeccb3608787f82c262a49fbb835dd3f10005dad)</span></li>
<li>gui/kmixerwidget.cpp <span style="color: grey">(bbfb13be55a2911f594559ca4ac02f0bc7256acc)</span></li>
<li>gui/kmixprefdlg.cpp <span style="color: grey">(bde7b15df1ae533d88c8774d71f508307a32c0c0)</span></li>
<li>gui/ksmallslider.cpp <span style="color: grey">(a681b4fd94481a6939b0d2edd7c4d9c9216a65d3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122159/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>