Review Request 121725: Fix kmix tray icon scrolling

[Christian Esken]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121725/#review74435
-----------------------------------------------------------

Ship it!


Thanks for your patch, Xuetian Weng. I think it solves the issues with high-precision devicess in a pretty smart way (adding the _delta_ state). And it definitely addresses the point I already mentioned in Bug 313579: "_Though this has the risk to break optimal use of alternative input devices (Touchpad, Track Pad, Trackball), I will consider to go this way._"

While personally I do not own high-precision devices (even my Logitech G500s delivers always +/-120 in all scrollwhel modes), I think the patch is really good, and will work properly for both high-precision and normal-precision devices.


-----
Side note:
The patch does not address the triple tray-wheel event outlined by "Enrico Tagliavini" in bug 313579, but I think application code should not even try to fix that (actually KMix has a config option that Søren Holm mentioned in bug 313579 as be usable as a workaround in the kmixrc: VolumePercentageStep=1.6666)

- Christian Esken


On Dec. 28, 2014, 9 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121725/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2014, 9 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Bugs: 313579 and 341536
>     http://bugs.kde.org/show_bug.cgi?id=313579
>     http://bugs.kde.org/show_bug.cgi?id=341536
> 
> 
> Repository: kmix
> 
> 
> Description
> -------
> 
> High-precision scroll is going to send scroll event with multiple small delta event. A simple way to fix it is to round it by 120 for a single increment.
> 
> The problem in 313579 is that the delta value is directly divided by 120. This patch add all delta value up and round it by 120.
> 
> 
> Diffs
> -----
> 
>   gui/kmixdockwidget.h a0d7a46 
>   gui/kmixdockwidget.cpp eeccb36 
> 
> Diff: https://git.reviewboard.kde.org/r/121725/diff/
> 
> 
> Testing
> -------
> 
> Plasma 5 + kmix scroll with trackpad.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150120/29a27291/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia