<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121725/">https://git.reviewboard.kde.org/r/121725/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for your patch, Xuetian Weng. I think it solves the issues with high-precision devicess in a pretty smart way (adding the <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">delta</em> state). And it definitely addresses the point I already mentioned in Bug 313579: "<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Though this has the risk to break optimal use of alternative input devices (Touchpad, Track Pad, Trackball), I will consider to go this way.</em>"</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While personally I do not own high-precision devices (even my Logitech G500s delivers always +/-120 in all scrollwhel modes), I think the patch is really good, and will work properly for both high-precision and normal-precision devices.</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Side note:
The patch does not address the triple tray-wheel event outlined by "Enrico Tagliavini" in bug 313579, but I think application code should not even try to fix that (actually KMix has a config option that Søren Holm mentioned in bug 313579 as be usable as a workaround in the kmixrc: VolumePercentageStep=1.6666)</p></pre>
<br />
<p>- Christian Esken</p>
<br />
<p>On December 28th, 2014, 9 p.m. UTC, Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia and Christian Esken.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2014, 9 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=313579">313579</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=341536">341536</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmix
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">High-precision scroll is going to send scroll event with multiple small delta event. A simple way to fix it is to round it by 120 for a single increment.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The problem in 313579 is that the delta value is directly divided by 120. This patch add all delta value up and round it by 120.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Plasma 5 + kmix scroll with trackpad.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>gui/kmixdockwidget.h <span style="color: grey">(a0d7a46)</span></li>
<li>gui/kmixdockwidget.cpp <span style="color: grey">(eeccb36)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121725/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>