Review Request 125357: make_fat32_compatible: Actually remove double quotes

[Christian Ehrlicher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125357/#review89729
-----------------------------------------------------------



utils/patternparser.cpp (line 373)
<https://git.reviewboard.kde.org/r/125357/#comment61470>

    Functional I don't see a problem here, but I think a simple loop over the string and checking for the problematic characters should be much faster then looping over the string 9 times and matching a QString ...
    QString s = string;
    for (int  i = 0; i < string.size(); ++i)
    {
      const QChar c = s.at(i);
      switch(c.toLatin1()) {
         case '\':
         case '/':
            ...
            s[i] = '_'
         default:
            break;
      }
    }


- Christian Ehrlicher


On Sept. 23, 2015, 11:29 vorm., Ian Schwarz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125357/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 11:29 vorm.)
> 
> 
> Review request for KDE Multimedia and Marco Nelles.
> 
> 
> Repository: audex
> 
> 
> Description
> -------
> 
> The encoding process fails whenever the option to produce FAT32 compatible filenames is enabled and a song title contains one or more double quotes.
> 
> 
> Diffs
> -----
> 
>   utils/patternparser.cpp 80cf81a 
> 
> Diff: https://git.reviewboard.kde.org/r/125357/diff/
> 
> 
> Testing
> -------
> 
> Compiles and fixes the problem.
> 
> 
> Thanks,
> 
> Ian Schwarz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20151219/ac142238/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia