Review Request 125357: make_fat32_compatible: Actually remove double quotes

[Ian Schwarz]

> On Sept. 23, 2015, 11:23 a.m., Harald Sitter wrote:
> > looks good to me considering the comment above the function even lists " as a character that is supposed to be replaced
> > 
> > > //remove \ / : * ? " < > |
> > 
> > You may want to add "marcon" to the reviewers since he is the author of the app.
> 
> Ian Schwarz wrote:
>     Double quotes are removed in several of the adjacent functions (i.e. `make_compatible` and `make_compatible2`). I figure the strings were supposed to be run through one of these in addidtion to `make_fat32_compatible`. Unfortunately, they don't seem to be. (Titles with double quotes are no problem if "produce FAT32 compatible filenames" is disabled.)

This isn't moving anywhere, marcon isn't responding. Can anyone else take over this review request?


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125357/#review85808
-----------------------------------------------------------


On Sept. 23, 2015, 11:29 a.m., Ian Schwarz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125357/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 11:29 a.m.)
> 
> 
> Review request for KDE Multimedia and Marco Nelles.
> 
> 
> Repository: audex
> 
> 
> Description
> -------
> 
> The encoding process fails whenever the option to produce FAT32 compatible filenames is enabled and a song title contains one or more double quotes.
> 
> 
> Diffs
> -----
> 
>   utils/patternparser.cpp 80cf81a 
> 
> Diff: https://git.reviewboard.kde.org/r/125357/diff/
> 
> 
> Testing
> -------
> 
> Compiles and fixes the problem.
> 
> 
> Thanks,
> 
> Ian Schwarz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20151218/d07ac528/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia