Review Request 124671: Add missing vlc_common.h include

Dāvis Mosāns davispuh at gmail.com
Fri Aug 14 23:38:25 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124671/
-----------------------------------------------------------

(Updated Aug. 14, 2015, 10:38 p.m.)


Status
------

This change has been marked as submitted.


Review request for Phonon and Harald Sitter.


Changes
-------

Submitted with commit c097217bc0fd61e0de04fd586ffa9fdbc53ca011 by D?vis Mos?ns to branch master.


Repository: phonon-vlc


Description
-------

Add missing vlc_common.h include.
Without it when compiling from VLC master branch it errors about undefined VLC_API
```
In file included from /mnt/KDE/kdesupport/phonon-vlc/src/video/videomemorystream.h:21:0,
                 from /mnt/KDE/kdesupport/phonon-vlc/src/video/videodataoutput.h:28,
                 from /mnt/KDE/kdesupport/phonon-vlc/src/backend.cpp:48:
/usr/include/vlc/plugins/vlc_fourcc.h: At global scope:
/usr/include/vlc/plugins/vlc_fourcc.h:568:1: error: ‘VLC_API’ does not name a type
VLC_API vlc_fourcc_t vlc_fourcc_GetCodec( int i_cat, vlc_fourcc_t i_fourcc );
```

PS. by the way there's loads of deprecation warnings.


Diffs
-----

  src/video/videomemorystream.h d779d3b7b50123f6ad32df4a10930f11748dd092 

Diff: https://git.reviewboard.kde.org/r/124671/diff/


Testing
-------

Compiles


Thanks,

Dāvis Mosāns

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150814/f2c0bd71/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list