Review Request 124671: Add missing vlc_common.h include

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124671/#review83762
-----------------------------------------------------------

Ship it!


Ship It!

- Harald Sitter


On Aug. 13, 2015, 9:45 a.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124671/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 9:45 a.m.)
> 
> 
> Review request for Phonon and Harald Sitter.
> 
> 
> Repository: phonon-vlc
> 
> 
> Description
> -------
> 
> Add missing vlc_common.h include.
> Without it when compiling from VLC master branch it errors about undefined VLC_API
> ```
> In file included from /mnt/KDE/kdesupport/phonon-vlc/src/video/videomemorystream.h:21:0,
>                  from /mnt/KDE/kdesupport/phonon-vlc/src/video/videodataoutput.h:28,
>                  from /mnt/KDE/kdesupport/phonon-vlc/src/backend.cpp:48:
> /usr/include/vlc/plugins/vlc_fourcc.h: At global scope:
> /usr/include/vlc/plugins/vlc_fourcc.h:568:1: error: ‘VLC_API’ does not name a type
> VLC_API vlc_fourcc_t vlc_fourcc_GetCodec( int i_cat, vlc_fourcc_t i_fourcc );
> ```
> 
> PS. by the way there's loads of deprecation warnings.
> 
> 
> Diffs
> -----
> 
>   src/video/videomemorystream.h d779d3b7b50123f6ad32df4a10930f11748dd092 
> 
> Diff: https://git.reviewboard.kde.org/r/124671/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150813/097ec06a/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia