Review Request 120664: Revert "clang compat fix (from Qt)"

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120664/#review68739
-----------------------------------------------------------

Ship it!


Ship It!

- Harald Sitter


On Oct. 19, 2014, 9:18 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120664/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2014, 9:18 p.m.)
> 
> 
> Review request for Phonon.
> 
> 
> Repository: phonon
> 
> 
> Description
> -------
> 
> The original Qt commit (3cba3745, "Phonon: Export ObjectDescriptionModel
> to prevent link errors with Clang") was a workaround for
> http://llvm.org/bugs/show_bug.cgi?id=8177, which was fixed more than 4
> years ago.
> 
> Now that we have proper support for clang in Phonon and build it with
> -fvisibility=hidden, the workaround started causing problems, as
> ObjectDescriptionModel::staticObject and others were not being exported
> as expected. A quick test for this is building Qt's phonon capabilities
> example.
> 
> This reverts commit 845e395ab3aba10dbd57207ad71fbbd6b422f107.
> 
> 
> Diffs
> -----
> 
>   phonon/objectdescriptionmodel.h 74339b5e64ee1ee48b8b2f783157b566a7f5c3f1 
> 
> Diff: https://git.reviewboard.kde.org/r/120664/diff/
> 
> 
> Testing
> -------
> 
> Built Qt4's examples/phonon/capabilities successfully.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20141020/9c9febdd/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia