Review Request 120664: Revert "clang compat fix (from Qt)"

Raphael Kubo da Costa rakuco at
Sun Oct 19 22:18:36 BST 2014

This is an automatically generated e-mail. To reply, visit:

Review request for Phonon.

Repository: phonon


The original Qt commit (3cba3745, "Phonon: Export ObjectDescriptionModel
to prevent link errors with Clang") was a workaround for, which was fixed more than 4
years ago.

Now that we have proper support for clang in Phonon and build it with
-fvisibility=hidden, the workaround started causing problems, as
ObjectDescriptionModel::staticObject and others were not being exported
as expected. A quick test for this is building Qt's phonon capabilities

This reverts commit 845e395ab3aba10dbd57207ad71fbbd6b422f107.


  phonon/objectdescriptionmodel.h 74339b5e64ee1ee48b8b2f783157b566a7f5c3f1 



Built Qt4's examples/phonon/capabilities successfully.


Raphael Kubo da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
kde-multimedia mailing list
kde-multimedia at

More information about the kde-multimedia mailing list