Review Request 118754: Make Juk report Paused on the mpris2 interface

James Smith smithjd15 at gmail.com
Sat Oct 11 00:10:58 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118754/
-----------------------------------------------------------

(Updated Oct. 10, 2014, 11:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Multimedia.


Repository: juk


Description
-------

Juk doesn't advertise paused over mpris2. Emit the paused state not the playing state in case of no errors / warnings. This means all cases where the player is not playing or stopped and actually idle. This works around a bug that only seems to be present with Juk and the VLC backend.


Diffs
-----

  playermanager.cpp 975243f 
  playermanager.h 6c7756e 
  mpris2/mediaplayer2player.cpp 080b43f 

Diff: https://git.reviewboard.kde.org/r/118754/diff/


Testing
-------

Compile, run. Watch Kmix debug.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20141010/9410abb2/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list