Review Request 120956: Fix include dirs in PhononConfig.cmake

Harald Sitter sitter at kde.org
Mon Nov 3 12:16:24 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120956/#review69721
-----------------------------------------------------------


this patch is wrong, the include would be met by ${PHONON_INCLUDE_DIR}/KDE (which contains Phonon/...)

-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AbstractAudioOutput
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AbstractMediaStream
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AbstractVideoOutput
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AddonInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AudioDevice
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AudioDeviceEnumerator
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AudioOutput
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AudioOutputDevice
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AudioOutputDeviceModel
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AudioOutputInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/BackendCapabilities
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/BackendInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/Effect
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/EffectDescription
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/EffectDescriptionModel
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/EffectInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/EffectParameter
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/EffectWidget
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/Global
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/MediaController
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/MediaNode
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/MediaObject
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/MediaObjectInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/MediaSource
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/ObjectDescription
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/ObjectDescriptionModel
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/Path
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/PlatformPlugin
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/SeekSlider
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/StreamInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/VideoPlayer
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/VideoWidget
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/VideoWidgetInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/VolumeFaderEffect
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/VolumeFaderInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/VolumeSlider

- Harald Sitter


On Nov. 3, 2014, 12:13 p.m., José Manuel  Santamaría Lema wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120956/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 12:13 p.m.)
> 
> 
> Review request for Phonon.
> 
> 
> Repository: phonon
> 
> 
> Description
> -------
> 
> While packaging KDE Frameworks and Plasma 5 I got the following error when building plasma-workspace:
> 
> In file included from ../../../phonon/platform_kde/kdeplatformplugin.cpp:37:0:
> ../../../phonon/platform_kde/kiomediastream.h:23:38: fatal error: Phonon/AbstractMediaStream: No such file or directory
> 
> include <Phonon/AbstractMediaStream>
> 
> The attached patch fixes the problem for me.
> 
> 
> Diffs
> -----
> 
>   PhononConfig.cmake.in f1f3e7c 
> 
> Diff: https://git.reviewboard.kde.org/r/120956/diff/
> 
> 
> Testing
> -------
> 
> Rebuilding the packages with the patch proposed.
> 
> 
> Thanks,
> 
> José Manuel  Santamaría Lema
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20141103/0bb2946b/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list