<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120956/">https://git.reviewboard.kde.org/r/120956/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this patch is wrong, the include would be met by ${PHONON_INCLUDE_DIR}/KDE (which contains Phonon/...)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AbstractAudioOutput
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AbstractMediaStream
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AbstractVideoOutput
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AddonInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AudioDevice
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AudioDeviceEnumerator
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AudioOutput
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AudioOutputDevice
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AudioOutputDeviceModel
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/AudioOutputInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/BackendCapabilities
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/BackendInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/Effect
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/EffectDescription
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/EffectDescriptionModel
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/EffectInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/EffectParameter
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/EffectWidget
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/Global
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/MediaController
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/MediaNode
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/MediaObject
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/MediaObjectInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/MediaSource
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/ObjectDescription
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/ObjectDescriptionModel
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/Path
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/PlatformPlugin
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/SeekSlider
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/StreamInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/VideoPlayer
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/VideoWidget
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/VideoWidgetInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/VolumeFaderEffect
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/VolumeFaderInterface
-- Installing: ./usr/include/phonon4qt5/KDE/Phonon/VolumeSlider</p></pre>
<br />
<p>- Harald Sitter</p>
<br />
<p>On November 3rd, 2014, 12:13 p.m. UTC, José Manuel Santamaría Lema wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Phonon.</div>
<div>By José Manuel Santamaría Lema.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2014, 12:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
phonon
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While packaging KDE Frameworks and Plasma 5 I got the following error when building plasma-workspace:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In file included from ../../../phonon/platform_kde/kdeplatformplugin.cpp:37:0:
../../../phonon/platform_kde/kiomediastream.h:23:38: fatal error: Phonon/AbstractMediaStream: No such file or directory</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">include <Phonon/AbstractMediaStream></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The attached patch fixes the problem for me.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Rebuilding the packages with the patch proposed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>PhononConfig.cmake.in <span style="color: grey">(f1f3e7c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120956/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>