Review Request 117887: audiocd-kio: Improve flac & cdrom support

[Casian Andrei]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117887/#review57903
-----------------------------------------------------------

Ship it!


Since there is no one around to make a thorough review, I took a quick look and the changes look clean and good.

But unfortunately, I am unable to test these changes.

If there is noone available to perform testing and/or a review, these changes should be committed, instead of being forgotten, in my opinion.

Anyway, I'm not sure whether this area of code is being maintained by anyone at the moment.


audiocd.cpp
<https://git.reviewboard.kde.org/r/117887/#comment40292>

    After a quick look, I don't understand what this does and I have no idea if it breaks anything. Is this ok?


- Casian Andrei


On April 29, 2014, 7:37 p.m., Pali Rohár wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117887/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 7:37 p.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Repository: audiocd-kio
> 
> 
> Description
> -------
> 
> This patch series can be found in my git repo at http://quickgit.kde.org/?p=clones/audiocd-kio/pali/audiocd-kio.git
> 
> * Set default flac compression level to 5 and use function FLAC__stream_encoder_set_compression_level() if possible (compiling against new libflac) 
> * Add flac tab settings for configuring compression level (only if FLAC__stream_encoder_set_compression_level is used)
> * When "?device=/dev/<device>" is not specified in audiocd:/ url show list of available cdrom devices instead using default cdrom device
> * Remove default cdrom device from audiocd settings tab (it is not used anymore)
> * Set all vorbis (and flac too) comment tag names in upper case for consistency with other KDE applications (e.g. Amarok)
> 
> 
> Diffs
> -----
> 
>   audiocd.cpp 5a21e1d7785ba7356d5212348180f962d590f121 
>   kcmaudiocd/audiocdconfig.ui 47028bb725c50101fecceecbcb70f669125a1940 
>   kcmaudiocd/kcmaudiocd.cpp 2198dbafeae453e7a05333db0c7330d1bc7167dc 
>   plugins/flac/CMakeLists.txt 46333389f3c5258b2b1b71e6dd3c4279c3ea71a8 
>   plugins/flac/audiocd_flac_encoder.kcfg PRE-CREATION 
>   plugins/flac/audiocd_flac_encoder.kcfgc PRE-CREATION 
>   plugins/flac/encoderflac.h 9c7b728526c02f89676e1d703a624c78423e85b7 
>   plugins/flac/encoderflac.cpp 964b4d1ca3011f36a09224a5b5b99fa8674bf8d4 
>   plugins/flac/encoderflacconfig.ui PRE-CREATION 
>   plugins/vorbis/encodervorbis.cpp 750b53fa3f9ecaadaa54296f35952dd6196b2bb3 
> 
> Diff: https://git.reviewboard.kde.org/r/117887/diff/
> 
> 
> Testing
> -------
> 
> This patch series needs testing different audio cds (cdda, mixed, etc ...) on other computers, ideally with multiple cdrom devices and on different distributions to make sure that it does not break anything.
> 
> 
> Thanks,
> 
> Pali Rohár
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140514/f1dac689/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia