<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117887/">https://git.reviewboard.kde.org/r/117887/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since there is no one around to make a thorough review, I took a quick look and the changes look clean and good.
But unfortunately, I am unable to test these changes.
If there is noone available to perform testing and/or a review, these changes should be committed, instead of being forgotten, in my opinion.
Anyway, I'm not sure whether this area of code is being maintained by anyone at the moment.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/117887/diff/1/?file=269274#file269274line1058" style="color: black; font-weight: bold; text-decoration: underline;">audiocd.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void AudioCDProtocol::parseURLArgs(const KUrl & url)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1023</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">groupCDDA</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="s">"autosearch"</span><span class="p">,</span> <span class="nb">true</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1049</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">d</span><span class="o">-></span><span class="n">device</span> <span class="o">=</span> <span class="n">QString</span><span class="p">();</span> <span class="c1">// clear device</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After a quick look, I don't understand what this does and I have no idea if it breaks anything. Is this ok?</pre>
</div>
<br />
<p>- Casian Andrei</p>
<br />
<p>On April 29th, 2014, 7:37 p.m. UTC, Pali Rohár wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Multimedia.</div>
<div>By Pali Rohár.</div>
<p style="color: grey;"><i>Updated April 29, 2014, 7:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
audiocd-kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch series can be found in my git repo at http://quickgit.kde.org/?p=clones/audiocd-kio/pali/audiocd-kio.git
* Set default flac compression level to 5 and use function FLAC__stream_encoder_set_compression_level() if possible (compiling against new libflac)
* Add flac tab settings for configuring compression level (only if FLAC__stream_encoder_set_compression_level is used)
* When "?device=/dev/<device>" is not specified in audiocd:/ url show list of available cdrom devices instead using default cdrom device
* Remove default cdrom device from audiocd settings tab (it is not used anymore)
* Set all vorbis (and flac too) comment tag names in upper case for consistency with other KDE applications (e.g. Amarok)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch series needs testing different audio cds (cdda, mixed, etc ...) on other computers, ideally with multiple cdrom devices and on different distributions to make sure that it does not break anything.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>audiocd.cpp <span style="color: grey">(5a21e1d7785ba7356d5212348180f962d590f121)</span></li>
<li>kcmaudiocd/audiocdconfig.ui <span style="color: grey">(47028bb725c50101fecceecbcb70f669125a1940)</span></li>
<li>kcmaudiocd/kcmaudiocd.cpp <span style="color: grey">(2198dbafeae453e7a05333db0c7330d1bc7167dc)</span></li>
<li>plugins/flac/CMakeLists.txt <span style="color: grey">(46333389f3c5258b2b1b71e6dd3c4279c3ea71a8)</span></li>
<li>plugins/flac/audiocd_flac_encoder.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/flac/audiocd_flac_encoder.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/flac/encoderflac.h <span style="color: grey">(9c7b728526c02f89676e1d703a624c78423e85b7)</span></li>
<li>plugins/flac/encoderflac.cpp <span style="color: grey">(964b4d1ca3011f36a09224a5b5b99fa8674bf8d4)</span></li>
<li>plugins/flac/encoderflacconfig.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/vorbis/encodervorbis.cpp <span style="color: grey">(750b53fa3f9ecaadaa54296f35952dd6196b2bb3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117887/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>