Review Request 112076: Fix bug where monitor won't powersave even with only audio content

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112076/#review47318
-----------------------------------------------------------


Why split the logic into the views?

I mean, I get that they are kinda dependent on the content, but the views themselves are not.
A video without audio (technically - as in: that is how it is supposed to work, except it doesn't right now) only has a videoview and no audioview. So the sleep inhibition actually wouldn't apply in case anyone ever got to refactor the views to work as they should (created on demand, depending on the content, not be there all the time for no good reason).

- Harald Sitter


On Sept. 17, 2013, 6:19 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112076/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2013, 6:19 a.m.)
> 
> 
> Review request for KDE Multimedia and Harald Sitter.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> Fixes an issue where playing audio content keeps the screen awake. Video content is supposed to, but with the new play URL button, dragon should allow the monitor to turn off.
> 
> 
> Diffs
> -----
> 
>   src/app/videoWindow.cpp a325a6e 
>   src/app/videoWindow.h ab61ed0 
>   src/app/stateChange.cpp 0edde72 
>   src/app/mainWindow.cpp f850820 
>   src/app/mainWindow.h 51ef72c 
>   src/app/audioView2.cpp f2ddc44 
>   src/app/audioView2.h 6c04b47 
> 
> Diff: https://git.reviewboard.kde.org/r/112076/diff/
> 
> 
> Testing
> -------
> 
> Compile, run-test
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140113/116f4061/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia