<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/112076/">https://git.reviewboard.kde.org/r/112076/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why split the logic into the views?
I mean, I get that they are kinda dependent on the content, but the views themselves are not.
A video without audio (technically - as in: that is how it is supposed to work, except it doesn't right now) only has a videoview and no audioview. So the sleep inhibition actually wouldn't apply in case anyone ever got to refactor the views to work as they should (created on demand, depending on the content, not be there all the time for no good reason).</pre>
<br />
<p>- Harald Sitter</p>
<br />
<p>On September 17th, 2013, 6:19 a.m. UTC, James Smith wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Multimedia and Harald Sitter.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2013, 6:19 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dragon
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes an issue where playing audio content keeps the screen awake. Video content is supposed to, but with the new play URL button, dragon should allow the monitor to turn off.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compile, run-test</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/app/videoWindow.cpp <span style="color: grey">(a325a6e)</span></li>
<li>src/app/videoWindow.h <span style="color: grey">(ab61ed0)</span></li>
<li>src/app/stateChange.cpp <span style="color: grey">(0edde72)</span></li>
<li>src/app/mainWindow.cpp <span style="color: grey">(f850820)</span></li>
<li>src/app/mainWindow.h <span style="color: grey">(51ef72c)</span></li>
<li>src/app/audioView2.cpp <span style="color: grey">(f2ddc44)</span></li>
<li>src/app/audioView2.h <span style="color: grey">(6c04b47)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/112076/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>